Group items tagged

implementation or a description of what we did

No more “Just a fix“, “Improvements” or “I made this, this, this and also this” comments.

not what you did

(not what you did)

UserService

UserDao

FacebookWS

User u

UserService uses UserDAO and FacebookWS

but don’t know how those dependencies are instantiated

And you shouldn’t really care, all that is important is that UserService depends on dao and webservice object.

BDD template given-when-then) tests are easy to read

@Entity

public class User

calling new User(“someName”,”somePassowrd”, “someOtherName”, “someOtherPassword”) becomes hardly readable and maintainable

code duplication

Maintaining this code would turn into a nightmare in no time

running the code above will throw an exception by the JPA provider,

Joshua Blooch gives fine example of builder pattern.

Instead of making the desired object directly, the client calls a constructor (or static factory) with all of the required parameters and gets a builder object. Then the client calls setter-like methods on the builder object to set each optional parameter of interest. Finally, the client calls a parameterless build method to generate the object, which is immutable. The builder is a static member class of the class it builds.

Coffee

public static class Builder

Builder(CoffeeType type, int cupSize)

Builder withMilk()

Coffee build()

Coffee(this)

private Coffee(Builder builder)

Coffee coffee = new Coffee.Builder(CoffeeType.Expresso, 3).withMilk().build();2}

especially if most of those parameters are optional.

For all entity attributes I create private fields

those that are obligatory become parameters for the public constructor

parameter-less constructor, I create one, but I give him

protected access level

protected